Merged
Conversation
|
Crate versions that have been updated:
Runtime version has been increased. |
Contributor
Author
Todos / Open issues
|
…o apopiak/weight-trader
…o apopiak/weight-trader
Contributor
Author
It will use regular |
…o apopiak/weight-trader
apopiak
commented
Jun 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
=======================================
Coverage 83.44% 83.44%
=======================================
Files 24 24
Lines 2935 2935
=======================================
Hits 2449 2449
Misses 486 486 Continue to review full report at Codecov.
|
Member
|
Task linked: CU-2kpe1ch Implement Weight Trader |
Contributor
Author
|
requires #493 (and includes its changes) |
enthusiastmartin
approved these changes
Jun 16, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The weight trader uses
pallet-transaction-multi-paymentto determine whether the payment asset has a local price (and can be used for fee payment).It then uses
WeightToFeein combination with that price to calculate the fee to charge for the weight.The trader tracks assets used for payment and uses them naively (i.e. one by one) to refund weight.
Related
closes #373
based on galacticcouncil/warehouse#48
Motivation and Context
Basilisk currently does not charge for XCM execution which makes it open for exploitation.
How Has This Been Tested?
Checklist: